Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icepack from Consortium main July 6, 2023 #25

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Update Icepack from Consortium main July 6, 2023 #25

merged 3 commits into from
Jul 7, 2023

Conversation

eclare108213
Copy link
Collaborator

  • Short (1 sentence) summary of your PR:
    Adds two recent Icepack PRs, including optional FSD arguments and changes to step_therm2
  • Developer(s):
    @eclare108213, @apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.

Tested 3-month E3SM D-case:

--- Average Differences for Month 03, Year 0001:

    D3.nseti3.updateIcepack20230706.updateIcepack20230706.eclare108213.anvil k000 - 
    D3.nseti3.updateIcepack20230706.icepack-integration.eclare108213.anvil k000:

    totalIceExtent:  	BFB
    totalIceVolume:  	BFB
    totalSnowVolume:  	BFB
    totalKineticEnergy:  	BFB
    averageAlbedo:  	BFB
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

apcraig and others added 3 commits June 20, 2023 10:40
@apcraig
update readthedocs.yaml, turn on pdf (CICE-Consortium#438)
31e85f2
@apcraig
Update icepack_step_therm2, make fsd arguments optional (CICE-Consort…
d024340 
…ium#440)

* Update icepack_step_therm2, make fsd arguments optional

* Update interface documentation

* Update user guide, change references from master to main

* update optional arguments in lower level routines for fsd step_therm2

* update documentation about optional arguments

* update documentation about optional arguments
@eclare108213
Merge branch 'main' of https://github.com/cice-consortium/icepack int…
dfb8e2c 
…o ibranch4
@eclare108213 eclare108213 self-assigned this Jul 6, 2023
@eclare108213 eclare108213 merged commit b2b8066 into cice-consortium/E3SM-icepack-initial-integration Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

@darincomeau darincomeau Awaiting requested review from darincomeau

Assignees

@eclare108213 eclare108213

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eclare108213 @apcraig